Similar color doesn't make a difference in spawning.. depends on what you are wanting out of your spawn.
The white male has cloudy eyes - very common for pure whites and often causes blindness/partial blindness as they age. You would have to be careful and watch carefully if you go full whitexwhite.
Honestly I would go with the black and you can work on a few different lines from that pairing - can work on getting white/black (or a mix of the two) in PK, HMPK, HMDT, DTPK, DTHM. So 5 varieties you can create by that pair by selective breeding the offsprings. Babies will be a black and white mix, may have some black/white marbles, some will have blue irids, etc.
The yellow would be pretty, could get some HMs and DTHMs.
Keep in mind the F1s may not have DTs, or there will be few.. breeding back to the mom, or siblingxsibling will increase chances of more DTs.. if don't want DTs then can breed a baby to the father and eventually work out the DTs.